fix: warn when using rest or identifier in custom elements without props option #16003
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9c4db99 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
dummdidumm
reviewed
May 26, 2025
Rich-Harris
approved these changes
May 27, 2025
<!-- A.svelte -->
<svelte:options customElement={{
tag: 'a-btn',
props: {
name: {type: 'String'},
}
}}/>
<script lang="ts">
import B from './B.svelte'
const props: {name: string} = $props()
</script>
<B name={props.name}/><!-- B.svelte -->
<script lang="ts">
const props: {name: string} = $props()
</script>
<button>{props.name}</button>Perhaps a trigger warning shouldn't be issued for file https://stackblitz.com/edit/vitejs-vite-1tpdpcqa?file=src%2FB.svelte 
|
|
Please open a new issue, comments on merged PRs will get lost |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sprouted from this bsky conversation
It could be quirky to debug such things so I think a warning could be nice if you have a Rest element or an Identifier as the declarator of
$propsAND don't have apropsoption forcustomElementOptions.I've added three test that maybe is too much but wanted to capture all three scenarios.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint